HDDS-10857. Rename rewriteGeneration to expectedDataGeneration in the protobuf and builders #6692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename rewriteGeneration to expectedDataGeneration.
This future proofs the name, so we can potentially have expectedMetaGeneration in the future.
It also better describes what the field is for - when passed, it indicates the existing key is "expected" to have a Data Generation of the given value, whether it is for read, write (potential future use cases) or re-write (the current use case).
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10857
How was this patch tested?
Just a name change so existing tests cover this.