HDDS-10371. NPE in OzoneAclUtils.isOwner #6676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@adoroszlai , thanks for working on this. Could you elaborate a bit more that how this lazy call can avoid NPE? |
Contributor
Author
|
NPE is avoided by swapping the order of |
hemantk-12
approved these changes
May 14, 2024
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
Thanks, @adoroszlai for the change.
LGTM+1.
Contributor
|
Thank you for this fix. |
Contributor
Author
|
Thanks @ChenSammi, @kerneltime, @smengcl for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 23, 2024
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 459feac)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 459feac)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 459feac)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
(cherry picked from commit 459feac)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
(cherry picked from commit 459feac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OzoneAclUtils.isOwner(and simplify condition)isOwnerlazilyhttps://issues.apache.org/jira/browse/HDDS-10371
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/9076402412