HDDS-10834. Revert snapshot diff output change added in HDDS-9360 #6660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swamirishi
approved these changes
May 8, 2024
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
Thanks for the patch @hemantk-12 LGTM
Contributor
Author
|
Thanks @swamirishi for the quick review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
…ache#6660) (cherry picked from commit 673c112)
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Jun 10, 2024
…DDS-9360 (apache#6660) Change-Id: Ib901b4b84b352fba5206ce6d043745bf68c9b7cf
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…ache#6660) (cherry picked from commit 673c112)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…ache#6660) (cherry picked from commit 673c112)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…ache#6660) (cherry picked from commit 673c112)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
…ache#6660) (cherry picked from commit 673c112)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
…ache#6660) (cherry picked from commit 673c112)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change potentially breaks the backward compatibility of the snapshot diff CLI command if the output of the CLI is used directly. Because SnapDiff doesn't support JSON output format as of now, we are reverting this change.
In the future, we will add JSON output support for SnapDiff (Jira: HDDS-10833) so that this type of change can be done without any backward compatibility issues. More details about JSON backward compatibility support: https://lists.apache.org/thread/5gqnbstv1pznwmcvx7txspj1qrksy7gl
What is the link to the Apache JIRA
HDDS-10834
How was this patch tested?
Existing tests.