HDDS-10780. NullPointerException in watchForCommit #6627
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
approved these changes
May 3, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
(cherry picked from commit e1d2d9c) Conflicts: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientRatis.java Change-Id: Ifca0361f4e24bf6bac9b8ce806c3e6f1f501c15a
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Oct 16, 2024
(cherry picked from commit e1d2d9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
See HDDS-10780.
We have NPE for the following scenarios. Let's say a pipeline
p1with dn1, dn2 and dn3.Some chunks are written to
p1-> flush 1 -> watchCommit 1 timed out because dn3 hasn't caught up to the latest index. -> dn3 is removed fromcommitInfoMap.Some other chunks are written to
p1-> flush 2 -> watchCommit 2 -> latest index has been committed to all dn1, dn2 and dn3 -> NPE because dn3 has been removed fromcommitInfoMap.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10780
How was this patch tested?
CI.