HDDS-10787. Use ManagedObject in rocksdb-checkpoint-differ instead of RocksObject #6625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
May 3, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @hemantk-12 for the patch, LGTM.
duongkame
approved these changes
May 3, 2024
Contributor
duongkame
left a comment
duongkame
left a comment
There was a problem hiding this comment.
Thanks for the patch @hemantk-12 . LGTM.
Contributor
Author
|
Thanks @adoroszlai and @duongkame for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
…objects (apache#6625) (cherry picked from commit c435a7f)
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Jun 10, 2024
…ged RocksDB objects (apache#6625) (cherry picked from commit c435a7f) Change-Id: Idc040dd029b7fd39e7f38ddae933be57b354a22b
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…objects (apache#6625) (cherry picked from commit c435a7f)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…objects (apache#6625) (cherry picked from commit c435a7f)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…objects (apache#6625) (cherry picked from commit c435a7f)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
…objects (apache#6625) (cherry picked from commit c435a7f)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
…objects (apache#6625) (cherry picked from commit c435a7f)
ptlrs
pushed a commit
to ptlrs/ozone
that referenced
this pull request
Mar 8, 2025
…ged RocksDB objects (apache#6625) (cherry picked from commit c435a7f) Change-Id: Idc040dd029b7fd39e7f38ddae933be57b354a22b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
rocksdb-checkpoint-differpackage is directly usingRocksObjectwhich causes a leak if not closed properly e.g. HDDS-10783, HDDS-10001.This change is to address RocksObject leak issue as described in HDDS-10008 and HDDS-10787.
ManagedObjecteverywhere inrocksdb-checkpoint-differexcept the CompactionListener.rocksdb-checkpoint-differRocksDBCheckpointDiffer.What is the link to the Apache JIRA
HDDS-10787, HDDS-10008
How was this patch tested?
No functional change so relying on exiting unit tests.