HDDS-10761. Add raft close threshold config to OM RaftProperties #6594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@szetszwo @adoroszlai Hi, could you help to review if you have time ? |
szetszwo
reviewed
Apr 28, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@whbing , thanks a lot for working on this!
- Let's don't have the formatting/whitespace changes here. It is hard to review. We may do it separately.
- Let's don't get the same conf twice. It makes it hard to see the relation of the ratis/ozone confs.
Please see also the comments inlined and also https://issues.apache.org/jira/secure/attachment/13068497/6594_review.patch
...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java
Show resolved
Hide resolved
...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java
Outdated
Show resolved
Hide resolved
szetszwo
approved these changes
Apr 28, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
@whbing , thanks for doing that.! How about submitting another pull request for the formatting changes? |
Contributor
Author
Contributor
Author
|
@szetszwo Thanks for review and merge ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OM crash as the following logs:
This pr makes the close-threshold value configurable from the OM side.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10761
How was this patch tested?
manual tests: debug ratis and trace the value.