HDDS-10719. Empty ETag for key created outside of S3 #6563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivandika3
reviewed
Apr 20, 2024
Contributor
ivandika3
left a comment
ivandika3
left a comment
There was a problem hiding this comment.
Thank you for the fix. I left a comment.
| this.replicationConfig = b.replicationConfig; | ||
| this.isFile = b.isFile; | ||
| this.eTag = b.eTag; | ||
| this.eTag = b.eTag != null && !b.eTag.isEmpty() ? b.eTag : null; |
Contributor
There was a problem hiding this comment.
Nit: It might be better to use StringUtils#isNotEmpty
if (StringUtils.isNotEmpty(b.eTag) {
this.eTag = b.eTag;
}
Contributor
There was a problem hiding this comment.
Or we might instead use an protobuf field existence check for eTag field on BasicOmKeyInfo#getFromProtobuf.
if (basicKeyInfo.hasETag()) {
builder.setETag(basicKeyInfo.getETag());
}
ivandika3
approved these changes
Apr 20, 2024
Contributor
ivandika3
left a comment
ivandika3
left a comment
There was a problem hiding this comment.
Thank you for the update. LGTM +1.
Contributor
Author
|
Thanks @ivandika3 for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
(cherry picked from commit 96fc70e)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Aug 14, 2024
(cherry picked from commit 96fc70e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid introducing empty
ETagin response for keys created outside of S3 Gateway (e.g. via Ozone CLI).https://issues.apache.org/jira/browse/HDDS-10719
How was this patch tested?
Added assertion in existing Robot test.
CI:
https://github.com/adoroszlai/ozone/actions/runs/8758764190