HDDS-10717. nodeFailureTimeoutMs should be initialized before syncTimeoutRetry #6560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
approved these changes
Apr 19, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
|
Thanks @ivandika3 for the patch, @szetszwo for the review. |
Contributor
Author
|
Thank you @szetszwo for the review and @adoroszlai for the merge. |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 23, 2024
…eoutRetry (apache#6560) (cherry picked from commit 5dbd3cf)
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
…eoutRetry (apache#6560) (cherry picked from commit 5dbd3cf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It is found that the Ratis WriteLog retry is "0/0" which means the WriteLog will not retry at all, and the datanode will trigger a pipeline failure to close the pipeline. This might cause a lot of pipeline close events sent by the datanodes during high IO events. Our cluster encountered this issue which caused pipeline thrashing issues (pipeline kept getting closed and created continuously).
The issue was due to
nodeFailureTimeoutMsinitialized AFTERnewRaftPropertiesandsetStateMachineDataConfigurationswhich causes an issue. HDDS-9821 removed the overwritten configuration, but at the same time exposed the bug.Need to fix the ordering so that it's the
syncTimeoutRetryis calculated correctly (default 30 times).What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10717
How was this patch tested?
Clean CI: https://github.com/ivandika3/ozone/actions/runs/8752866026