HDDS-10692. ozone s3 getsecret prints some internal details #6531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishkumar50
approved these changes
Apr 16, 2024
Contributor
ashishkumar50
left a comment
ashishkumar50
left a comment
There was a problem hiding this comment.
@adoroszlai Thanks for the patch, LGTM.
Contributor
Author
|
Thanks @ashishkumar50, @ssulav for the review. |
Tejaskriya
pushed a commit
to Tejaskriya/ozone
that referenced
this pull request
Apr 17, 2024
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 17, 2024
) (cherry picked from commit 72240fa)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 18, 2024
) (cherry picked from commit 72240fa)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 18, 2024
) (cherry picked from commit 72240fa)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 21, 2024
) (cherry picked from commit 72240fa)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 23, 2024
) (cherry picked from commit 72240fa)
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
) (cherry picked from commit 72240fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ozone s3 getsecretprints some additional items since HDDS-9444.The last two lines are internal details, should be omitted.
https://issues.apache.org/jira/browse/HDDS-10692
How was this patch tested?
Added assertion in robot test.
CI:
https://github.com/adoroszlai/ozone/actions/runs/8693821050