HDDS-10643. Avoid terminating SCM by statemachine during normal SCM stop. #6478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumitagrawl
approved these changes
Apr 8, 2024
Contributor
sumitagrawl
left a comment
sumitagrawl
left a comment
There was a problem hiding this comment.
@ashishkumar50 LGTM, when explicitly close() is called by SCMHAManager, that time transaction buffer and other close is done. No need call shutdown if already triggered.
Tejaskriya
pushed a commit
to Tejaskriya/ozone
that referenced
this pull request
Apr 17, 2024
…top. (apache#6478) Co-authored-by: ashishk <[email protected]>
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
…top. (apache#6478) Co-authored-by: ashishk <[email protected]> (cherry picked from commit b8faba6)
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Jun 10, 2024
…normal SCM stop. (apache#6478) Co-authored-by: ashishk <[email protected]> (cherry picked from commit b8faba6) Change-Id: Idb1390ed278fbd9e79ad5fdd30337e1e993f9727
ivandika3
pushed a commit
to ivandika3/ozone
that referenced
this pull request
Oct 12, 2025
…top. (apache#6478) Co-authored-by: ashishk <[email protected]> (cherry picked from commit b8faba6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently during normal SCM stop it's going into deadlock situation, detail is in Jira.
During normal SCM stop we should not terminate SCM through statemachine when called by ratis. Instead SCM should stop all the worker threads and shutdown gracefully.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10643
How was this patch tested?
Verified in the cluster for graceful exit