HDDS-9200. [Snapshot] Added logs and metrics for snapshot purge and set property APIs #6453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smengcl
reviewed
Apr 2, 2024
...anager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotPurgeRequest.java
Show resolved
Hide resolved
swamirishi
reviewed
Apr 3, 2024
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
Thanks for the patch @hemantk-12 Overall LGTM apart from one of the logging done.
...anager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotPurgeRequest.java
Show resolved
Hide resolved
smengcl
approved these changes
Apr 3, 2024
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Thanks @hemantk-12 . lgtm
.../java/org/apache/hadoop/ozone/om/request/snapshot/TestOMSnapshotPurgeRequestAndResponse.java
Show resolved
Hide resolved
Contributor
Author
|
Thanks @smengcl and @swamirishi for the review. |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 17, 2024
…et property APIs (apache#6453) (cherry picked from commit 3467db1)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 18, 2024
…et property APIs (apache#6453) (cherry picked from commit 3467db1)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 23, 2024
…et property APIs (apache#6453) (cherry picked from commit 3467db1)
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
…et property APIs (apache#6453) (cherry picked from commit 3467db1)
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Jun 10, 2024
… purge and set property APIs (apache#6453) Change-Id: Idbb2fb15100a46d0b117e84f7443d94cb58ace94
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Dec 3, 2025
…erty APIs (apache#6453) Change-Id: I715238c692552e5883c3ecdfa42de1f7738e92c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For snapshot purge and set snapshot property, there is no OM log or audit log. Without logs, it is hard to debug an issue like Snapshot chain corruption (e.g. HDDS-10524).
This change is to add logs so that, there is a way to know which snapshot is updated by which request. It also adds metrics for
SnapshotPurgeRequestandSetSnapshotPropertyRequestAPIs for monitoring purposes.What is the link to the Apache JIRA
HDDS-9200
How was this patch tested?
Updated existing unit tests to validate that metrics are populated correctly.