Skip to content

Conversation

@will-sh
Copy link
Contributor

@will-sh will-sh commented Mar 27, 2024

What changes were proposed in this pull request?

HDDS-9764. Add Robot test for JSON output where missing

Please describe your PR in detail:

  • Added robot test for:
    ozone admin container info "${CONTAINER}" --json
    ozone admin container report --json
    ozone admin datanode usageinfo -m --json
  • Added missing JSON keys in incomplete command ozone admin container

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9764

How was this patch tested?

CI/acceptance workflow run on the fork git repo

Test Incomplete command:
https://github.com/will-sh/ozone/actions/runs/8447788465/job/23139219880#step:5:733
Test List containers as JSON:
https://github.com/will-sh/ozone/actions/runs/8447788465/job/23139219880#step:5:727
Test Report containers as JSON :
https://github.com/will-sh/ozone/actions/runs/8447788465/job/23139219880#step:5:729
Get usage info as JSON:
https://github.com/will-sh/ozone/actions/runs/8447788465/job/23139219880#step:5:772

@kerneltime
Copy link
Contributor

LGTM. Thanks for working on this.

@adoroszlai adoroszlai merged commit 140cf0f into apache:master Mar 28, 2024
@adoroszlai
Copy link
Contributor

Thanks @will-sh for the patch, @kerneltime for the review.

@will-sh
Copy link
Contributor Author

will-sh commented Mar 28, 2024

Thanks for the review @kerneltime @adoroszlai

@will-sh will-sh deleted the HDDS-9764 branch March 28, 2024 09:48
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants