Skip to content

Conversation

@jojochuang
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-10591. [hsync] improve block token refresh message.

Please describe your PR in detail:
Usually an expired block token received by a DataNode is refreshed properly. However the relevant log messages look scary and confusing.

  • Some of the logs should tone down. Instead of ERROR, it should be a WARN, because the exception will be retried.
  • The log messages surrounding block token refresh should be more clear.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10591

How was this patch tested?

Log message only. Existing unit tests should suffice.

Change-Id: If0e713678ee34ccbd74da5f20975bf7bb62fee29
@jojochuang jojochuang added the hbase HBase on Ozone support label Mar 26, 2024
@jojochuang jojochuang requested review from ChenSammi and smengcl March 27, 2024 00:37
Change-Id: I328b7e363b6c8ca2c0b2dc0453a08f34bf139420
Change-Id: I689c514c0634ef9328f461958bdd4ad24a5d91a6
@jojochuang jojochuang requested a review from ChenSammi April 2, 2024 03:58
…nd possible in unsecure environment.

Change-Id: I4627fc7ac2fe9ac6f77d22273a80cb40177f488f
…orage/BlockInputStream.java

Co-authored-by: Siyao Meng <[email protected]>
@jojochuang jojochuang requested a review from smengcl April 5, 2024 15:45
Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks @jojochuang for the patch!

@jojochuang jojochuang merged commit d4314c9 into apache:HDDS-7593 Apr 5, 2024
@jojochuang
Copy link
Contributor Author

Merged. Thanks Siyao and Sammi

chungen0126 pushed a commit to chungen0126/ozone that referenced this pull request May 3, 2024
chungen0126 pushed a commit to chungen0126/ozone that referenced this pull request May 3, 2024
jojochuang added a commit to jojochuang/ozone that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hbase HBase on Ozone support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants