HDDS-10574. Improve TestObjectPut #6426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
requested review from
ChenSammi,
duongkame,
guohao-rosicky and
xichen01
Contributor
Author
|
Can someone please review? The goal of this change is to prepare this unit test for an upcoming bugfix (reducing change in the patch for the real fix). |
Contributor
Author
|
@ivandika3 please take a look |
Contributor
Author
|
Thanks @ivandika3 for the review, your PR is merged and this one is updated. @duongkame can you please also review? |
adoroszlai
requested review from
aswinshakil and
hemantk-12
and removed request for
ChenSammi,
guohao-rosicky and
xichen01
hemantk-12
approved these changes
Mar 27, 2024
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
Thanks, @adoroszlai for the cleanup.
Overall change looks good to me.
Contributor
Author
|
Thanks @hemantk-12, @ivandika3 for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
(cherry picked from commit e68183e)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Aug 14, 2024
(cherry picked from commit e68183e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve
TestObjectPut:This is in preparation for HDDS-10570.
https://issues.apache.org/jira/browse/HDDS-10574
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/8401371232