HDDS-10560. Link rocksdb lib to Ozone rocksdb tools lib relative path instead of absolute path #6414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of absolute path
Contributor
|
Please wait for clean CI run in fork before opening PR. |
Contributor
Author
|
Got a clean CI on my fork. Opening the PR |
Contributor
Author
|
smengcl
reviewed
Mar 21, 2024
kerneltime
reviewed
Mar 22, 2024
...-rocksdb/src/main/java/org/apache/hadoop/hdds/utils/db/managed/JniLibNamePropertyWriter.java
Outdated
Show resolved
Hide resolved
Change-Id: Iefef7f05466bef2f955dc29966f35e6e29af4698
Contributor
|
The cmake changes look fine. I will try to find some time to give this PR a spin locally and complete the review. |
Change-Id: Ic08cbe1d369c3048db6bd2c27b42a2bcd09e929a
kerneltime
approved these changes
Apr 8, 2024
Contributor
Author
|
thank you for the review @kerneltime @smengcl |
Tejaskriya
pushed a commit
to Tejaskriya/ozone
that referenced
this pull request
Apr 17, 2024
… instead of absolute path (apache#6414)
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
… instead of absolute path (apache#6414) (cherry picked from commit e31e68a)
swamirishi
added a commit
to swamirishi/ozone
that referenced
this pull request
Jun 10, 2024
…elative path instead of absolute path (apache#6414) (cherry picked from commit e31e68a) Change-Id: I02f472bae587cebc3c91382cf1d2061b8dd3f740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently the native lib load fails since we hardcode the rocksdbjni lib path while linking with the native lib. We need to link it with a relative path.
The patch looks into setting the RPATH for native lib which will link the rocksdblib corresponding to the location of the native lib.
I am adding the stack overflow link which might be helpful here for reviewing:
https://stackoverflow.com/questions/43330165/how-to-link-a-shared-library-with-cmake-with-relative-path/71321163#71321163
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10560
How was this patch tested?
Existing Unit test