HDDS-10535. Remove unused RangerRestMultiTenantAccessController. #6392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@adoroszlai @prashantpogde @smengcl could you please review it. Forked CI also passed :- https://github.com/ArafatKhan2198/ozone/actions/runs/8313745667 |
adoroszlai
approved these changes
Mar 17, 2024
smengcl
approved these changes
Mar 17, 2024
Contributor
|
Thanks @ArafatKhan2198 for the patch, @smengcl for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
While working on my task, I found an old class you wrote called
RangerRestMultiTenantAccessController. It seems like we're not using it anywhere and upon further looking, it became evident that this implementation has been replaced byRangerClientMultiTenantAccessController.Also, since we're migrating all GSON implementations to Jackson in the following PR, and this class heavily uses GSON for JSON parsing, it's another reason to remove it.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10535
How was this patch tested?
I successfully removed the file from the project and rebuilt it without encountering any issues.