HDDS-9802. Tool to fix corrupted snapshot chain #6386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemantk-12
changed the title
adoroszlai
reviewed
Mar 16, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @hemantk-12 for the patch. Found some typos, and suggested some minor improvements.
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/SnapshotRepair.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/SnapshotRepair.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/SnapshotRepair.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/SnapshotRepair.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/SnapshotRepair.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/SnapshotRepair.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/SnapshotInfo.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/SnapshotRepair.java
Outdated
Show resolved
Hide resolved
aswinshakil
approved these changes
Mar 19, 2024
Member
aswinshakil
left a comment
aswinshakil
left a comment
There was a problem hiding this comment.
Thanks for this tool @hemantk-12. Really helpful in fixing snapshot chain corruption. LGTM+1
Contributor
Author
|
Thanks, @adoroszlai and @aswinshakil for the review. |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 17, 2024
(cherry picked from commit e907316)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 18, 2024
(cherry picked from commit e907316)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 23, 2024
(cherry picked from commit e907316)
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Jun 10, 2024
) (cherry picked from commit e907316) Change-Id: I67950ede21d47449ce433b629e1a8f24a1d88a19
ivandika3
added
snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the past, we have seen many instances (HDDS-8530, HDDS-8832, and recently HDDS-10524) when SnapshotChain corruption was causing OM to get stuck on restart. Lots of bugs related to snapshot chain corruption have been fixed but we still issue some occurrences here and there (HDDS-10524 is a very recent one).
This change is to implement a tool that can be used to repair the snapshot chain corruption once a corrupted entry is identified.
The idea for this tool is from HDDS-8100. This change also provides a base setup for HDDS-8100 and can be extended to provide support for other cases HDDS-8101, HDDS-8824, HDDS-10295, etc.
What is the link to the Apache JIRA
HDDS-9802
How was this patch tested?
Tested it on the docker.