HDDS-9842. Cache volume capacity and available space #6383
Merged
+160
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojochuang
reviewed
Mar 15, 2024
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
This is good also (see #6381)
xichen01
reviewed
May 15, 2024
Contributor
xichen01
left a comment
xichen01
left a comment
There was a problem hiding this comment.
@adoroszlai Thanks for your work on this!
Cache the capacity and available does reduce the system call when writing file. especially in small file scenario. but for some scenario such as shared disks with other service. it may result the Container can not be recognized as a full Container.
So, this a trade-off between performance and correctness.
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/fs/CachingSpaceUsageSource.java
Show resolved
Hide resolved
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/fs/CachingSpaceUsageSource.java
Show resolved
Hide resolved
Contributor
|
LGTM+1. |
smengcl
approved these changes
Jul 8, 2024
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
lgtm. Thanks @adoroszlai
Contributor
Author
|
Thanks @jojochuang, @smengcl, @xichen01 for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently
CachingSpaceUsageSourceonly cachesusedSpace, since that piece of information is most expensive to collect when usingdu.This patch changes the class to also cache
capacityandavailable.https://issues.apache.org/jira/browse/HDDS-9842
How was this patch tested?
Updated unit test.
CI:
https://github.com/adoroszlai/ozone/actions/runs/8294068655