HDDS-10503. Bump jgrapht to 1.4.0

[ivanzlenko]

What changes were proposed in this pull request?

Jgrapht library was updated to the most recent version.

What is the link to the Apache JIRA

HDDS-10503

How was this patch tested?

New unit tests added to cover PrintableGraph class.

[adoroszlai]

License header is needed in all files. Example:

ozone/hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigFileAppender.java

Lines 1 to 17 in 131eec0

	/*
	* Licensed to the Apache Software Foundation (ASF) under one
	* or more contributor license agreements. See the NOTICE file
	* distributed with this work for additional information
	* regarding copyright ownership. The ASF licenses this file
	* to you under the Apache License, Version 2.0 (the
	* "License"); you may not use this file except in compliance
	* with the License. You may obtain a copy of the License at
	* <p>
	* http://www.apache.org/licenses/LICENSE-2.0
	* <p>
	* Unless required by applicable law or agreed to in writing, software
	* distributed under the License is distributed on an "AS IS" BASIS,
	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	* See the License for the specific language governing permissions and
	* limitations under the License.
	*/

[ivanzlenko]

I guess we need more informative output in rat.sh and mark build failed :)
~/projects/opensource/ozone hadoop-hdds/rocksdb-checkpoint-differ/target/rat.txt: !????? /home/izlenko/projects/opensource/ozone/hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/graph/TestPrintableGraph.java izlenko:~/projects/open
I've totally missed that.

[adoroszlai]

I guess we need more informative output in rat.sh

Agreed.

and mark build failed

I don't see any problem there, the check failed: https://github.com/ivanzlenko/ozone/actions/runs/8233075581/job/22511818434

[ivanzlenko]

[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  17.799 s
[INFO] Finished at: 2024-03-11T17:44:03+05:00
[INFO] ------------------------------------------------------------------------
[INFO] 26 goals, 26 executed
~/projects/opensource/ozone
hadoop-hdds/rocksdb-checkpoint-differ/target/rat.txt: !????? /home/izlenko/projects/opensource/ozone/hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/graph/TestPrintableGraph.java

Whole output from console.

[adoroszlai]

rat.sh exits with error code.

$ echo $?
1

BUILD SUCCESS is printed only because hadoop-hdds and hadoop-ozone are checked separately, the latter is successful. This will be improved in #6358, which changes the build to run a single Maven command for the whole project.

[ivanzlenko]

Thanks!

[myskov]

Thanks @ivanzlenko for the patch!

[myskov]

I suggest using EnumSource, it will allow:

• get rid of graphTypes() method
• No need in modifying this test if a new value is added to the enum

[ivanzlenko]

Thanks for feedback! Changed to EnumSource

[adoroszlai]

Unfortunately JGraphT 1.5.x requires Java 11.

https://sourceforge.net/p/jgrapht/news/2020/06/jgrapht-version-150-released/

[ivanzlenko]

@adoroszlai yeah, I've downgraded it to 1.4.0. It still contains newer version of jgraphx, so it should be okay.

[adoroszlai]

Thanks @ivanzlenko for updating the patch.

It looks like new version has slightly different transitive dependencies. Please update LICENSE.txt and jar-report.txt:
https://github.com/apache/ozone/actions/runs/8234045319/job/22516088723?pr=6364#step:5:10

[adoroszlai]

Thanks @ivanzlenko for the patch, LGTM.

[myskov]

Thanks for the update @ivanzlenko.
Thanks for reviewing @adoroszlai.