HDDS-10504. Remove unused VolumeInfo#configuredCapacity #6363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lement separate query methods)
adoroszlai
added
the
code-cleanup
myskov
approved these changes
Mar 11, 2024
Contributor
myskov
left a comment
myskov
left a comment
There was a problem hiding this comment.
Thanks for the patch @adoroszlai, LGTM
Contributor
Author
|
Thanks @myskov for the review. |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 0763985)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 0763985)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 0763985)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
(cherry picked from commit 0763985)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
(cherry picked from commit 0763985)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
VolumeInfo#configuredCapacityis unused, can be removed.Also: let
VolumeUsagenot implementSpaceUsageSource. Long term goal is to access all space usage properties ofVolumeUsagevia a single call tosnapshot(). Removingimplementsis a first step to removing individual methods likegetAvailable().https://issues.apache.org/jira/browse/HDDS-10504
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/8231787063