HDDS-10480. Avoid proto2 ByteString.toByteArray() calls. #6342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duongkame
reviewed
Mar 7, 2024
|
|
||
| final SCMRatisResponseProto responseProto = SCMRatisResponseProto | ||
| .parseFrom(response); | ||
| final SCMRatisResponseProto responseProto = SCMRatisResponseProto.parseFrom(response.toByteArray()); |
Contributor
There was a problem hiding this comment.
Can use the below to avoid creating new buffer too.
final SCMRatisResponseProto responseProto = SCMRatisResponseProto.parseFrom(response.newInput());
Contributor
Author
There was a problem hiding this comment.
@duongkame , thanks for reviewing this!
The method parseFrom(InputStream) will call new CodedInputStream(InputStream), which creates a byte[] in the CodedInputStream constructor. Since it is InputStream, it probably will copy at least two times.
Contributor
Author
|
@duongkame , thanks a lot for reviewing this! |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Oct 16, 2024
(cherry picked from commit d94aadc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Some proto2
ByteString.toByteArray()calls can be removed in order to avoid buffer copying.What is the link to the Apache JIRA
HDDS-10480
How was this patch tested?
By existing tests.