Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Audit log for key creation is missing information about EC replication (see replicationFactor=ZERO).

2024-03-05 18:53:20,425 | INFO  | OMAudit | user=hadoop | ip=172.18.0.5 | op=COMMIT_KEY {volume=smxvvmay, bucket=cgszxdst, key=PUTFILE2.txt._COPYING_, dataSize=17289, replicationType=EC, replicationFactor=ZERO} | ret=SUCCESS |  

https://issues.apache.org/jira/browse/HDDS-10472

How was this patch tested?

Verified OM audit log for EC key creation in acceptance tests:

2024-03-06 10:31:50,226 | INFO  | OMAudit | user=dlfknslnfslf | ip=172.18.0.2 | op=ALLOCATE_KEY {volume=s3v, bucket=erasure, key=testfile, dataSize=29, replicationType=EC, replicationConfig=rs-3-2-1048576} | ret=SUCCESS |  
2024-03-06 10:31:51,434 | INFO  | OMAudit | user=dlfknslnfslf | ip=172.18.0.2 | op=COMMIT_KEY {volume=s3v, bucket=erasure, key=testfile, dataSize=29, replicationType=EC, replicationConfig=rs-3-2-1048576} | ret=SUCCESS |  

Log for Ratis keys is unchanged:

2024-03-06 10:33:02,190 | INFO  | OMAudit | user=dlfknslnfslf | ip=172.18.0.2 | op=ALLOCATE_KEY {volume=s3v, bucket=destbucket-94098, key=ozone-test-5769387323/copyobject/key=value/f1, dataSize=29, replicationType=NONE} | ret=SUCCESS |  
2024-03-06 10:33:02,498 | INFO  | OMAudit | user=dlfknslnfslf | ip=172.18.0.2 | op=COMMIT_KEY {volume=s3v, bucket=destbucket-94098, key=ozone-test-5769387323/copyobject/key=value/f1, dataSize=29, replicationType=RATIS, replicationFactor=THREE} | ret=SUCCESS |  

https://github.com/adoroszlai/ozone/actions/runs/8170275505

@adoroszlai adoroszlai self-assigned this Mar 6, 2024
@adoroszlai adoroszlai requested a review from sodonnel March 6, 2024 12:38
Copy link
Contributor

@tanvipenumudy tanvipenumudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @adoroszlai, LGTM

@adoroszlai adoroszlai merged commit 309e459 into apache:master Mar 6, 2024
@adoroszlai adoroszlai deleted the HDDS-10472 branch March 6, 2024 19:13
@adoroszlai
Copy link
Contributor Author

Thanks @sodonnel, @tanvipenumudy for the review.

jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Mar 15, 2024
(cherry picked from commit 309e459)
Change-Id: I0bd39d42cdf6222752c8d12cff12fc2e9487cc23
myskov pushed a commit to myskov/ozone that referenced this pull request Apr 3, 2024
myskov pushed a commit to myskov/ozone that referenced this pull request Apr 3, 2024
myskov pushed a commit to myskov/ozone that referenced this pull request Apr 3, 2024
myskov pushed a commit to myskov/ozone that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants