HDDS-10471. [hsync] MockDatanodeStorage.writeChunk should make a copy of byte string. #6334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of byte string. Change-Id: Icbe2bdb6e744011a6df3842a5f6019078a516aa9 (cherry picked from commit ef66416)
Contributor
|
Thanks @jojochuang ! lgtm pending CI: https://github.com/smengcl/hadoop-ozone/actions/runs/8167227322 |
smengcl
approved these changes
Mar 6, 2024
Contributor
|
Thanks @jojochuang for the fix. There is a separate failure on my branch CI above that is likely caused by my merge effort and is unrelated to this PR. Merging this in a minute. |
smengcl
pushed a commit
to smengcl/hadoop-ozone
that referenced
this pull request
Mar 6, 2024
… of byte string. (apache#6334)
chungen0126
pushed a commit
to chungen0126/ozone
that referenced
this pull request
May 3, 2024
… of byte string. (apache#6334)
chungen0126
pushed a commit
to chungen0126/ozone
that referenced
this pull request
May 3, 2024
… of byte string. (apache#6334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix a memory corruption in test utility caused by (potentially unsafe) memory manipulation.
Please describe your PR in detail:
Found in HDDS-10431 (#6286). For some reason it only fails for Linux not Mac.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10471
How was this patch tested?
Unit test.