HDDS-10265. Use SnapshotId in BackgroundServices. #6296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemantk-12
reviewed
Mar 28, 2024
| try { | ||
| if (fromSnapshot != null) { | ||
| if (purgeDirsRequest.hasSnapshotTableKey()) { | ||
| throw new OMException("The field snapshotTableKey from PurgeDirectoriesRequest is deprecated." + |
Contributor
There was a problem hiding this comment.
If I understood the code flow properly, it would fail OM which is not good in this scenario.
Based on OzoneManagerStateMachine#processResponse and https://issues.apache.org/jira/browse/HDDS-10524
May be better to fall back to purgeDirsRequest.getSnapshotTableKey() or throw FILE_NOT_FOUND or something which doesn't fail OM.
We also need to fix this for the snapshot chain as well. Right now it crashes OM if the chain is corrupted. e.g. HDDS-10524
Member
Author
|
Closing this PR. I will create a different PR for this as the Snapshot code has changed significantly since the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
With #6006, We support snapshot rename operation. Many of the background services sends
OMRequestwith respect tosnapshotTableKey. If there is a rename operation that happens in-between the request, It will fail and the system may be in an undesirable state. In this PR, Instead of usingsnapshotTableKeywe are changing the background services to usesnapshotIdwhich remains constant throughout a snapshot's lifetime.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10265
How was this patch tested?
Existing Tests.