HDDS-10252. [hsync] Revisit configuration keys for incremental chunk list after HDDS-9884 #6289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to full chunk list, if DataNode has not finished upgrade.
Contributor
Author
|
CC: @ashishkumar50 |
ChenSammi
reviewed
Feb 28, 2024
| <property> | ||
| <name>ozone.chunk.list.incremental</name> | ||
| <value>false</value> | ||
| <value>true</value> |
Contributor
There was a problem hiding this comment.
@jojochuang , I would suggest to change the "ozone.chunk.list.incremental" to "ozone.incremental.chunk.list",
to be consist with another property name "ozone.client.incremental.chunk.list".
ChenSammi
approved these changes
Mar 1, 2024
Contributor
There was a problem hiding this comment.
The last patch looks good. Thanks @jojochuang .
smengcl
pushed a commit
to smengcl/hadoop-ozone
that referenced
this pull request
Mar 6, 2024
…list after HDDS-9884 (apache#6289)
chungen0126
pushed a commit
to chungen0126/ozone
that referenced
this pull request
May 3, 2024
…list after HDDS-9884 (apache#6289)
chungen0126
pushed a commit
to chungen0126/ozone
that referenced
this pull request
May 3, 2024
…list after HDDS-9884 (apache#6289)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable ozone.fs.hsync.enabled, ozone.chunk.list.incremental, ozone.client.incremental.chunk.list by default.
Please describe your PR in detail:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10252
How was this patch tested?
Unit test