HDDS-9235. ReplicationManager metrics not collected after restart. #6280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Seems to be some related unit test failures. |
sodonnel
approved these changes
Feb 28, 2024
Contributor
|
Thanks @aswinshakil for the patch, @sodonnel for the review. |
adoroszlai
pushed a commit
to adoroszlai/ozone
that referenced
this pull request
Mar 5, 2024
…pache#6280) (cherry picked from commit 543c9e7)
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Mar 15, 2024
…pache#6280) (cherry picked from commit 543c9e7) Change-Id: I85eae2e0372cd8458c847ecb4685394bf4a1c62b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ReplicationManager can be stopped/restarted by admin from CLI.
stop()unregisters the metrics source, andstart()used to (re)create it. But now after #5126 it isn't re-created, so it won't work after restart. This patch fixes that by initiatingReplicationManagerMetricsagain duringstart()with the same instance.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9235
How was this patch tested?
Existing Tests.