HDDS-10268. [hsync] Add OpenTracing traces to client side read path #6262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojochuang
changed the title
Contributor
|
Thanks for this change! Looking at the read chart, 50% of the latency is from getting block information which is redundant as DN can calculate the chunk and offset to read. Hope this one gets picked up soon https://issues.apache.org/jira/browse/HDDS-10338 |
Contributor
Change-Id: I06a8f5a0342ed53e08174090a4922f8785e06a0d
smengcl
approved these changes
Apr 6, 2024
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Thanks @jojochuang for adding the new spans and tags. lgtm
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/RootedOzoneFileSystem.java
Show resolved
Hide resolved
…RootedOzoneFileSystem.java Co-authored-by: Siyao Meng <[email protected]>
Change-Id: I6888d0ba3fa8366f04e1d065a83b8f7af5c134ff
Contributor
|
Retriggered CI |
Contributor
|
@duongkame @kerneltime @tanvipenumudy please review |
Contributor
|
Thanks @jojochuang for the patch. |
Tejaskriya
pushed a commit
to Tejaskriya/ozone
that referenced
this pull request
Apr 17, 2024
jojochuang
added a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
…pache#6262) (cherry picked from commit cedb459) Conflicts: hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/RootedOzoneFileSystem.java Change-Id: Icc8735a213cbd95b0ae65b50f506ad4ac2caa5ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add client side trace spans to ofs file system APIs and input/output stream APIs.
Select screenshots:
input stream read()
outputstream hsyc
file system contentSummary API
file system create file API
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10268
How was this patch tested?
Tested in a dev cluster.