HDDS-10361. [hsync] Output stream should support direct byte buffer. #6256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smengcl
reviewed
Feb 23, 2024
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Thanks Wei-Chiu for the fix.
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java
Outdated
Show resolved
Hide resolved
smengcl
approved these changes
Feb 23, 2024
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
lgtm. We can merge this to feature branch first providing that the CI passes.
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java
Outdated
Show resolved
Hide resolved
…orage/BlockOutputStream.java Co-authored-by: Siyao Meng <[email protected]>
smengcl
added a commit
to smengcl/hadoop-ozone
that referenced
this pull request
Mar 6, 2024
…pache#6256) Co-authored-by: Siyao Meng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A small update to HDDS-9752 such that it works for direct buffers too.
Please describe your PR in detail:
HDDS-9752 assumed the byte buffer is heap buffer which has a backing byte array. It's no longer the case after HDDS-9843 which uses direct buffer, so we need to adapt the code to support that.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10361
How was this patch tested?
Unit tests