HDDS-10405. ozone admin has hard-coded info loglevel #6254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ozone admincommands use loggers to print to standard output. They ignore logging configuration due to hard-coded info level. Log output also lack details like timestamp, thread name, etc. to mimic regular output.This change replaces
LOG.infowith printing toSystem.out,LOG.errorwith printing toSystem.err. Log messages from other parts of the code can now be displayed if needed.LOGmessages are kept inUpgradeManagerandUpgradeTask(container layout v2 to v3 upgrade tool, introduced recently), which have more complex output. I think they can benefit from using regular logging.https://issues.apache.org/jira/browse/HDDS-10405
How was this patch tested?
Tested few commands manually in
ozonecompose environment.Tested debug level logging with
log4j.logger.org.apache.hadoop.security.SaslRpcClient=DEBUG:CI:
https://github.com/adoroszlai/ozone/actions/runs/7994077722