HDDS-10403. CopyObject should set ETag based on the key content #6251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kerneltime @myskov Could you help to review this when convenient? Thank you. |
Contributor
|
@vtutrinov could you also take a look, please? |
Contributor
|
@ivandika3 thanks for the patch! @myskov LGTM, +1 |
myskov
reviewed
Feb 22, 2024
| METRICS.updateCopyKeyMetadataStats(startNanos); | ||
| perf.appendMetaLatencyNanos(metadataLatencyNs); | ||
| writeLen = writeToStreamOutput(streamOutput, body, bufferSize, length); | ||
| eTag = DatatypeConverter.printHexBinary(body.getMessageDigest().digest()) |
Contributor
There was a problem hiding this comment.
As the eTag var is not used anywhere else, let's move eTag declaration here.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. Updated. PTAL.
ivandika3
changed the title
myskov
approved these changes
Feb 23, 2024
Contributor
myskov
left a comment
myskov
left a comment
There was a problem hiding this comment.
Thanks @ivandika3 for updating the patch. LGTM
Contributor
|
Thanks @ivandika3 for the patch, @myskov, @vtutrinov for the review. |
Contributor
Author
|
Thank you for the reviews @myskov @vtutrinov and @adoroszlai for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently copyObject does not seem to support eTag based on key's content. It uses a random UUID in CopyObjectResponse.
We need to change this to be the eTag based on the key content instead.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10403
How was this patch tested?
Unit tests, acceptance test, and manual tests.
Compatibilities
Clean CI run: https://github.com/ivandika3/ozone/actions/runs/8001415597