HDDS-10387. Fix parameter number warning in KeyOutputStream and the related classes #6225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandakumar131
approved these changes
Feb 20, 2024
Contributor
nandakumar131
left a comment
nandakumar131
left a comment
There was a problem hiding this comment.
LGTM. Thanks @szetszwo for working on this.
adoroszlai
approved these changes
Feb 20, 2024
Contributor
|
Thanks @szetszwo for the patch, @nandakumar131 for the review. |
Contributor
Author
|
@nandakumar131, @adoroszlai , thanks a lot for reviewing this! |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 11, 2024
…ed classes (apache#6225) (cherry picked from commit c672453)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We fix the @SuppressWarnings({"parameternumber", "squid:S00107"}) in
What is the link to the Apache JIRA
HDDS-10387
How was this patch tested?
By the existing tests.