-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-10340. Skip ci on dashboard updates #6203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kerneltime for working on this.
Filtering checks based on paths is performed by dev-support/ci/selective_ci_checks.sh. Please add it to the pattern here:
ozone/dev-support/ci/selective_ci_checks.sh
Lines 233 to 237 in c1efa33
| local ignore_array=( | |
| "^hadoop-ozone/dist/src/main/k8s" | |
| "^hadoop-ozone/dist/src/main/license" | |
| "\.md$" | |
| ) |
and here:
ozone/dev-support/ci/selective_ci_checks.sh
Lines 481 to 497 in c1efa33
| # Counts other files which do not need to trigger any functional test | |
| # (i.e. no compose/integration/kubernetes) | |
| function get_count_misc_files() { | |
| start_end::group_start "Count misc. files" | |
| local pattern_array=( | |
| "^dev-support/ci/pr_title_check" | |
| "^.github" | |
| "^hadoop-hdds/dev-support/checkstyle" | |
| "^hadoop-ozone/dev-support/checks" | |
| "^hadoop-ozone/dev-support/intellij" | |
| "^hadoop-ozone/dist/src/main/license" | |
| "\.bats$" | |
| "\.txt$" | |
| "\.md$" | |
| "findbugsExcludeFile.xml" | |
| "/NOTICE$" | |
| ) |
We also have a unit test for this script. Please add a test case similar to the following, using the hash of a commit that only changed dashboard files (e.g. 039dea9):
ozone/dev-support/ci/selective_ci_checks.bats
Lines 400 to 410 in c1efa33
| @test "IntelliJ config" { | |
| run dev-support/ci/selective_ci_checks.sh 92bf0913b6 | |
| assert_output -p 'basic-checks=["rat"]' | |
| assert_output -p needs-build=false | |
| assert_output -p needs-compile=false | |
| assert_output -p needs-compose-tests=false | |
| assert_output -p needs-dependency-check=false | |
| assert_output -p needs-integration-tests=false | |
| assert_output -p needs-kubernetes-tests=false | |
| } |
You can then test it locally by running:
hadoop-ozone/dev-support/checks/bats.sh
|
Thanks will do! |
Change-Id: Iad966750ea821605bba21aafe4b9b423b977749c
a27238d to
91c624b
Compare
adoroszlai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok 3 dashboard only
What changes were proposed in this pull request?
Currently there are no test for dashboard changes but the PRs still run the entire CI workflow.
Skip the CI if only the dashboards have been updated.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10340
How was this patch tested?
Pushed this change and a dashboard change to https://github.com/kerneltime/ozone/commits/HDDS-10339-skip-ci/