HDDS-10301. Recon - Fold the pipeline info for a DN on Datanode page. #6198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myskov
reviewed
Feb 9, 2024
...one/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx
Outdated
Show resolved
Hide resolved
...one/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx
Outdated
Show resolved
Hide resolved
devmadhuu
approved these changes
Feb 12, 2024
Contributor
devmadhuu
left a comment
devmadhuu
left a comment
There was a problem hiding this comment.
Thanks @smitajoshi12 for working on this patch. LGTM +1
dombizita
reviewed
Feb 12, 2024
...one/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx
Outdated
Show resolved
Hide resolved
dombizita
requested changes
Feb 14, 2024
...one/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx
Outdated
Show resolved
Hide resolved
dombizita
approved these changes
Feb 14, 2024
Contributor
dombizita
left a comment
dombizita
left a comment
There was a problem hiding this comment.
Thanks for addressing the review comments @smitajoshi12, it looks good to me!
ArafatKhan2198
approved these changes
Feb 15, 2024
Contributor
ArafatKhan2198
left a comment
ArafatKhan2198
left a comment
There was a problem hiding this comment.
Thanks for working on this @smitajoshi12
LGTM +1
Contributor
|
Thanks for working on this @smitajoshi12! Thank you for the review @myskov, @devmadhuu and @ArafatKhan2198! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We are displaying only first 3 PipelinesID's and remaining pipelinesId's we displaying in popup after over on text
... and N more pipelines
###Please describe your PR in detail:
As discussed in APAC community sync:
Suggested one improvement on Recon UI, fold the pipeline info for a DN on Datanode page. When a Datanode has more than 10 pipelines, it will display all the pipelines by default, which is not necessary most of the time.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10301
How was this patch tested?
Manually
Before this PR
With this PR
