Skip to content

HDDS-8683. Container balancer thread interrupt may not work #6179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddhantsangwan merged 4 commits into from
Feb 28, 2024
Merged

HDDS-8683. Container balancer thread interrupt may not work #6179

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
800b237
HDDS-8683. Container balancer thread interrupt may not work
Feb 6, 2024
3bcfb20
Remove duplicate line
Feb 6, 2024
60fa8dd
Check isBalancerRunning before sleep for delayStart
Feb 9, 2024
025a9c5
Revert "Check isBalancerRunning before sleep for delayStart"
Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...cm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@ public void run() {
TimeUnit.SECONDS);
LOG.info("ContainerBalancer will sleep for {} seconds before starting" +
" balancing.", delayDuration);
Thread.sleep(Duration.ofSeconds(delayDuration).toMillis());
if (isBalancerRunning()) {
Thread.sleep(Duration.ofSeconds(delayDuration).toMillis());
}
Copy link
Contributor

@adoroszlai adoroszlai Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the bug report is not about this sleep, rather the one in:

ozone/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java

Lines 229 to 237 in 60fa8dd

long sleepTime = 3 * nodeReportInterval;
LOG.info("ContainerBalancer will sleep for {} ms while waiting " +
"for updated usage information from Datanodes.", sleepTime);
Thread.sleep(sleepTime);
} catch (InterruptedException e) {
LOG.info("Container Balancer was interrupted while waiting for" +
"datanodes refreshing volume usage info");
Thread.currentThread().interrupt();
return;

}
balance();
} catch (Exception e) {
Expand Down