HDDS-10152. Field should be static #6168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Feb 5, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sarvekshayr for working on this.
- Please remove files under
hadoop-ozone/integration-test/container.db, they are leftover after running some tests. - There are some checkstyle failures, see results at https://github.com/sarvekshayr/ozone/actions/runs/7783793573/job/21222995834
...ction-test/mini-chaos-tests/src/test/java/org/apache/hadoop/ozone/MiniOzoneChaosCluster.java
Outdated
Show resolved
Hide resolved
adoroszlai
added
the
code-cleanup
tanvipenumudy
approved these changes
Feb 6, 2024
Contributor
tanvipenumudy
left a comment
tanvipenumudy
left a comment
There was a problem hiding this comment.
Thank you @sarvekshayr for the patch!
LGTM +1, pending Git CI.
adoroszlai
reviewed
Feb 6, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @sarvekshayr for updating the patch.
Noticed some very minor issues:
- avoid access to
staticviathis - let's keep "user1", "user2" in comments instead of using constant's name, since that's the actual value
...gration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
Outdated
Show resolved
Hide resolved
...gration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
Outdated
Show resolved
Hide resolved
...gration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
Outdated
Show resolved
Hide resolved
...gration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
Outdated
Show resolved
Hide resolved
...gration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
Outdated
Show resolved
Hide resolved
...gration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
Outdated
Show resolved
Hide resolved
...gration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
Outdated
Show resolved
Hide resolved
...gration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
Outdated
Show resolved
Hide resolved
...gration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
Outdated
Show resolved
Hide resolved
...gration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerListVolumesSecure.java
Outdated
Show resolved
Hide resolved
adoroszlai
approved these changes
Feb 6, 2024
Contributor
|
Thanks @sarvekshayr for the patch, @tanvipenumudy for the review. |
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Dec 3, 2025
(cherry picked from commit 789c7f0) Change-Id: If6f45ff43c09fe5f6cd931a585ad73567660e150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changing the fields mentioned in the HDDS-10152.txt from final to static final. Renaming the variables and its subsequent appearance to ALL_CAPS format.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10152
How was this patch tested?
Patch was tested by running the test class and the corresponding test class of server-side class to ensure that the changes made ran successfully without throwing an error.