HDDS-10277. Remove unnecessary fail() from tests #6166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemantk-12
reviewed
Feb 5, 2024
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
Thanks @wzhallright for the clean up.
Overall looks good to me (+1). Left few minor comments.
...test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestContainerStateMachineFailures.java
Outdated
Show resolved
Hide resolved
...est/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneClientRetriesOnExceptions.java
Outdated
Show resolved
Hide resolved
...ace-storage/src/test/java/org/apache/hadoop/ozone/om/helpers/TestRepeatedOmKeyInfoCodec.java
Outdated
Show resolved
Hide resolved
...ace-storage/src/test/java/org/apache/hadoop/ozone/om/helpers/TestRepeatedOmKeyInfoCodec.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@hemantk-12 Thanks for your review! I have fixed the comments. PTAL. |
Contributor
|
Thanks @wzhallright for the patch, @hemantk-12 for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unnecessary fail() from tests
What is the link to the Apache JIRA
HDDS-10277
CI
https://github.com/wzhallright/ozone/actions/runs/7783088108