HDDS-10242. [hsync] Handle penultimate block finalization. #6164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishkumar50
changed the title
Contributor
Author
|
@ChenSammi @jojochuang Please help to review, thanks. |
Contributor
|
This PR needs a rebase. Sorry. |
ashishkumar50
force-pushed
the
HDDS-10242
branch
from
e95b35a to
8aa8a36
Compare
smengcl
reviewed
Feb 8, 2024
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/LeaseKeyInfo.java
Outdated
Show resolved
Hide resolved
jojochuang
reviewed
Feb 9, 2024
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
Makes sense.
Looks like a lot of duplicate code in the various FileSystem classes. Can consider extract and de-dup them later.
hadoop-ozone/ozonefs-hadoop3/src/main/java/org/apache/hadoop/fs/ozone/OzoneFileSystem.java
Show resolved
Hide resolved
jojochuang
approved these changes
Feb 10, 2024
Contributor
|
Merged. Thanks @ashishkumar50 for fixing the bug and @smengcl for the review. |
smengcl
pushed a commit
to smengcl/hadoop-ozone
that referenced
this pull request
Mar 6, 2024
Co-authored-by: ashishk <[email protected]>
chungen0126
pushed a commit
to chungen0126/ozone
that referenced
this pull request
May 3, 2024
Co-authored-by: ashishk <[email protected]>
chungen0126
pushed a commit
to chungen0126/ozone
that referenced
this pull request
May 3, 2024
Co-authored-by: ashishk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
During leaseRecovery if final block doesn't exist in datanode(when data still not yet flushed to datanode for the last block) but exist in openFileTable. In this case recovery client should finalize the penultimate block and the lease recovery should succeed with the penultimate block length.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10242
How was this patch tested?
New integration test.