Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  1. setStreamBufferSize is never used: it can be removed
  2. enableContainerDatastream, numOfOmHandlers, numOfScmHandlers are never changed:
    • values can be defined in ozone-site.xml
    • member variables and their usage can be removed
  3. setClusterId, setOmId and setScmId are only called with UUID.randomUUID().toString():
    • setOmId, setScmId can be completely removed
    • setClusterId is kept for internal use (MiniOzoneCluster and MiniOzoneClusterProvider)
    • few tests that need the actual clusterId value are changed to use cluster.getClusterId()

Additional minor cleanup in TestOzoneFsHAURLs and TestOzoneManagerConfiguration, mostly required by the removal of omId:

  • remove unnecessary creation of OMStorage
  • use @TempDir

https://issues.apache.org/jira/browse/HDDS-10289

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/7773770796

@adoroszlai adoroszlai added test code-cleanup Changes that aim to make code better, without changing functionality. labels Feb 4, 2024
@adoroszlai adoroszlai self-assigned this Feb 4, 2024
@adoroszlai adoroszlai requested a review from fapifta February 4, 2024 13:12
@nandakumar131
Copy link
Contributor

nandakumar131 commented Feb 5, 2024

Thanks @adoroszlai for working on this.
Overall the change looks good to me.
Just one minor comment, will falling back to the default for OM & SCM handler count (100) have any performance impact on the tests?
This is updated via ozone-site.xml in test.

Copy link
Contributor

@fapifta fapifta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adoroszlai for this PR, it is really great to see the test setup made simpler.

The patch looks good to me!

@fapifta fapifta merged commit 80e9fb8 into apache:master Feb 5, 2024
@adoroszlai
Copy link
Contributor Author

Thanks @fapifta, @nandakumar131 for the review.

@adoroszlai adoroszlai deleted the HDDS-10289 branch February 5, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-cleanup Changes that aim to make code better, without changing functionality. test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants