HDDS-10148. TestOmSnapshotFsoWithNativeLib should be tagged as native test #6160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swamirishi
approved these changes
Feb 3, 2024
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
thanks for the patch @adoroszlai LGTM
Contributor
Author
|
Thanks @swamirishi for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Tag
TestOmSnapshotFsoWithNativeLibas@Native. Native lib is only available inunit (native)check (to reduce build time). Only tests tagged as@Nativeare run in this check.Without the lib, the test is a duplicate of
TestOmSnapshotFsoWithoutNativeLib.Really using the native library uncovered failures (HDDS-10149), thus the test needs to be marked as
@Unhealthy.https://issues.apache.org/jira/browse/HDDS-10148
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7768401409