HDDS-10287. Remove unused ozone.trace.enabled config and related code
#6159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
added
the
code-cleanup
fapifta
approved these changes
Feb 5, 2024
Contributor
fapifta
left a comment
fapifta
left a comment
There was a problem hiding this comment.
Thank you @adoroszlai for this PR. +1
Contributor
Author
|
Thanks @fapifta for the reviewing and merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
MiniOzoneClusterhas a setting to enable trace level logging, but it is never set totrue. Setting trace level logging globally is also useless, would result in too verbose logs. Setting level for specific loggers as needed is more helpful.This PR proposes to remove
enableTraceand related code.Config key
ozone.trace.enabledcan also be removed, since it is not used elsewhere. (The description says it is useful for debugging the REST protocol. Which was removed in favor of S3 Gateway years ago: HDDS-738.)https://issues.apache.org/jira/browse/HDDS-10287
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7768321799