HDDS-10279. Remove unused, dead code in hdds-config module. #6152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fapifta
added
the
code-cleanup
adoroszlai
approved these changes
Feb 2, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @fapifta for the patch.
Contributor
|
@fapifta Thank you for the patch, looking good to me. Also good thinking about checking reflections. |
Contributor
|
Thanks @Galsza for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removing dead code from hdds-config module. Dead code besides that it is not used can be harmful, if someone starts to use it, as it was not used it might not have been updated either along with similar functionality, so it is better to get rid of it.
Please describe your PR in detail:
The PR is, removing unused code from hdds-config module.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10279
How was this patch tested?
Functionality should not be changing, if the code compiles, and existing tests are running fine, that pretty much proves that we did not needed these methods.
On the other hand, due to potential reflective access it is hard to prove that complete methods are not called, therefore I ran a search for the method name in the codebase and checked for that manually.