HDDS-10274. Remove unused code related to AccessPolicy #6150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fapifta
approved these changes
Feb 2, 2024
Contributor
fapifta
left a comment
fapifta
left a comment
There was a problem hiding this comment.
Thank you @adoroszlai for joining forces in removing unused code, the change looks good to me.
fapifta
added
the
code-cleanup
smengcl
approved these changes
Feb 3, 2024
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai . lgtm. cc @prashantpogde
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove
AccessPolicyand related code, which is unused and leftover after HDDS-6909.Motivation (beyond code cleanup):
AccessPolicy#deserializePolicyFromJsonStringis defined using GSON datatypeJsonObject. We should strive to avoid using types defined in third-party libraries as part of public API. Such usage may cause trouble when trying to upgrade/replace these dependencies.https://issues.apache.org/jira/browse/HDDS-10274
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7745385510