HDDS-10229. Fixes for dashboards #6120
Conversation
kerneltime
changed the title
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/reconciliation.sdt
Outdated
Show resolved
Hide resolved
kerneltime
force-pushed
the
HDDS-10229
branch
from
a8b7204 to
2b68d4f
Compare
tanvipenumudy
left a comment
tanvipenumudy
left a comment
There was a problem hiding this comment.
Thank you for the patch!
| "datasource": { | ||
| "type": "prometheus", | ||
| "uid": "${DS_PROMETHEUS-1}" | ||
| "uid": "${DS_PROMETHEUS}" |
There was a problem hiding this comment.
Datasource ${DS_PROMETHEUS} was not found
I have checked out the patch locally and tried viewing the dashboards using Graphana via a docker-compose cluster with the monitoring add-ons, the variable: DS_PROMETHEUS does not get resolved automatically - not sure if it has something to do with my local settings! (please find the image attached).
I tried removing the uid field under datasource after which I do not run into this issue - I get to see the graphs as expected.
"datasource": {
"type": "prometheus"
},
There was a problem hiding this comment.
Did you import it as a new dashboard?
There was a problem hiding this comment.
While adding a new dashboard (by importing the .json file) and selecting the Prometheus source, I can see the graphs. However, when attempting to view graphs for the existing dashboards, I encounter the error message: Datasource ${DS_PROMETHEUS} was not found (by default).
There was a problem hiding this comment.
I was able to reproduce the issue. It only impacts the pre provisioned Dashboards in the dev environment but should be ok for any customer importing a dashboard. I will update with the fix that makes it work for both.
There was a problem hiding this comment.
Dear ozone comiters,
The latest Grafana is depreciating certain visual currently used within the current object-metrics dashboard.
I've updated upon recent expectation hope this helps.
Grafaa version Grafana v10.4.0 (03f502a94d)
Ozone - Object Metrics update dahsboards.json
There was a problem hiding this comment.
Thanks @PhilippeLan will include these changes.
Change-Id: Iccbf8ef5ab63232e739fc2bb58e4e107696febcc
kerneltime
force-pushed
the
HDDS-10229
branch
from
2b68d4f to
932f646
Compare
duongkame
left a comment
duongkame
left a comment
There was a problem hiding this comment.
Thanks for the patch @kerneltime . LGTM.
|
Thanks @kerneltime for the patch, @duongkame, @tanvipenumudy for the review. |
5 participants
What changes were proposed in this pull request?
There are some fixes needed for various dashboards published.
Details are in the linked jira.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10229
How was this patch tested?
Dashboard was imported to my dev cluster and validated against load generation.