Skip to content

HDDS-10202. OmMetadataManagerImpl creates new S3Batcher for each operation #6088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 2 commits into from
Jan 25, 2024
Merged

HDDS-10202. OmMetadataManagerImpl creates new S3Batcher for each operation #6088

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3735c2c
HDDS-10202. OmMetadataManagerImpl creates new S3Batcher for each oper…
adoroszlai Jan 24, 2024
98c6d4d
convert S3Batcher to inner class
adoroszlai Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 21 additions & 19 deletions ...p-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,7 @@ public class OmMetadataManagerImpl implements OMMetadataManager,
private final Map<String, TableCacheMetrics> tableCacheMetricsMap =
new HashMap<>();
private SnapshotChainManager snapshotChainManager;
private final S3Batcher s3Batcher = new S3SecretBatcher();

/**
* OmMetadataManagerImpl constructor.
Expand Down Expand Up @@ -1958,25 +1959,7 @@ public void revokeSecret(String kerberosId) throws IOException {

@Override
public S3Batcher batcher() {
return new S3Batcher() {
@Override
public void addWithBatch(AutoCloseable batchOperator,
String id, S3SecretValue s3SecretValue)
throws IOException {
if (batchOperator instanceof BatchOperation) {
s3SecretTable.putWithBatch((BatchOperation) batchOperator,
id, s3SecretValue);
}
}

@Override
public void deleteWithBatch(AutoCloseable batchOperator, String id)
throws IOException {
if (batchOperator instanceof BatchOperation) {
s3SecretTable.deleteWithBatch((BatchOperation) batchOperator, id);
}
}
};
return s3Batcher;
}

@Override
Expand Down Expand Up @@ -2188,4 +2171,23 @@ public boolean containsIncompleteMPUs(String volume, String bucket)

return false;
}

private final class S3SecretBatcher implements S3Batcher {
@Override
public void addWithBatch(AutoCloseable batchOperator, String id, S3SecretValue s3SecretValue)
throws IOException {
if (batchOperator instanceof BatchOperation) {
s3SecretTable.putWithBatch((BatchOperation) batchOperator,
id, s3SecretValue);
}
}

@Override
public void deleteWithBatch(AutoCloseable batchOperator, String id)
throws IOException {
if (batchOperator instanceof BatchOperation) {
s3SecretTable.deleteWithBatch((BatchOperation) batchOperator, id);
}
}
}
}