HDDS-10180. Update proto.lock from Ozone 1.4.0 #6080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@adoroszlai Thank you for the fix. I was wondering if we must use [email protected] for the lock generation in the future? |
Contributor
Author
No, the new version will be fine. |
Contributor
Confirmed no more error or warnings. LGTM. |
symious
approved these changes
Jan 24, 2024
Contributor
Author
|
@errose28 would you like to take a look? |
errose28
approved these changes
Jan 24, 2024
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks for taking care of the proto updates @adoroszlai
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Continue #6044 with additional changes from #6074.
https://issues.apache.org/jira/browse/HDDS-10180
How was this patch tested?
mvn -DskipTests clean verifyCI build:
https://github.com/adoroszlai/ozone/actions/runs/7636117693/job/20802633998