HDDS-9065. [FSO]ListKeys: Incorrect result when keyPrefix matching multiple exist keys.

[sadanand48]

What changes were proposed in this pull request?

Fix cases when the keyPrefix pertains to a particular file/dir . For more details on the problem check jira description.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9065

How was this patch tested?

Unit tests.

[sadanand48]

@whbing would you like to take a look?

[whbing]

@sadanand48 Thanks for working on this ! Overall looks good.
Since this issue has been around for a long time, a similar method listStatusLight has been added , and I'm not sure if there is a similar problem in listStatusLight. Such as follow:

ozone/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java

Lines 1638 to 1639 in 2434689

	List<OzoneFileStatusLight> statuses = proxy.listStatusLight(volumeName,
	name, keyPrefix, false, startKey, listCacheSize, true);

[whbing]

NIT: To avoid reaching methodlength, perhaps we can organize the code a bit. We can eliminate some unnecessary line breaks because there is no longer an 80-character line limit. Such as the following.

ozone/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneListStatusHelper.java

Lines 96 to 102 in 2434689

	final String bucketKey = metadataManager.getBucketKey(volumeName,
	bucketName);
	final OmVolumeArgs volumeInfo = metadataManager.getVolumeTable()
	.get(volumeKey);
	final OmBucketInfo omBucketInfo = metadataManager.getBucketTable()
	.get(bucketKey);

[TaiJuWu]

Is there a good tool which can help us format this project?

[adoroszlai]

Maybe even can be split into several methods (validate parameters, handle different cases, collect results, etc.).

[sadanand48]

Thanks , I have refactored the method now.

[sadanand48]

I'm not sure if there is a similar problem in listStatusLight

Thanks for the review @whbing , listStatusLight calls listStatus internally, It only trims the keyInfo object to be sent over the wire.

[aryangupta1998]

LGTM

[aryangupta1998]

Thanks @sadanand48 for the patch, @TaiJuWu, @adoroszlai, and @whbing for the reviews!