Skip to content

Conversation

@hemantk-12
Copy link
Contributor

@hemantk-12 hemantk-12 commented Jan 23, 2024

What changes were proposed in this pull request?

TestOmSnapshot.testSnapDiffWithMultipleSSTs was failing all the time because snapshot diff is an async API and when a job is submitted for the first time, it always returns empty diff list with IN_PROGRESS status. User is supposed to make second call to fetch the results, once job is DONE. TestOmSnapshot.testSnapDiffWithMultipleSSTs was only making one call which only submits the request and returned empty diff response as mentioned above.
This change is to call snap diff after job to DONE to fetch complete diff report.

What is the link to the Apache JIRA

HDDS-8005

How was this patch tested?

@hemantk-12 hemantk-12 added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Jan 23, 2024
@sadanand48
Copy link
Contributor

sadanand48 commented Jan 23, 2024

Thanks @hemantk-12 , overall change looks good . Could you also please run the flaky test workflow for this test a few times.

Copy link
Member

@aswinshakil aswinshakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. We can just run thefalky-test-check just to be sure. Otherwise I'm good with the changes.

@hemantk-12
Copy link
Contributor Author

hemantk-12 commented Jan 23, 2024

Initially, I didn't run the flaky-test-check because this test was marked Unhealthy not Flaky which means it failed all the times.

Just to be sure as suggested above, I ran it for 5x10 for TestOmSnapshotObjectStore: https://github.com/hemantk-12/ozone/actions/runs/7630045775 and it passed all the times.

@hemantk-12 hemantk-12 merged commit cc293e6 into apache:master Jan 23, 2024
@hemantk-12
Copy link
Contributor Author

Thanks @sadanand48 and @aswinshakil for the review.

Tejaskriya pushed a commit to Tejaskriya/ozone that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot https://issues.apache.org/jira/browse/HDDS-6517 test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants