Skip to content

HDDS-10059. TestOMRatisSnapshots.testInstallSnapshot should only validate live files. #6069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 8 commits into from
Jan 29, 2024
Merged

HDDS-10059. TestOMRatisSnapshots.testInstallSnapshot should only validate live files. #6069

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d138bd
broken
Jan 22, 2024
d0b1937
fix break
Jan 22, 2024
5521786
fixed
Jan 22, 2024
897830d
fix checkstyle
Jan 22, 2024
df58ab3
disabling compaction on loading trn #
Jan 22, 2024
9c14aef
remove compaction disable
Jan 23, 2024
4494f80
Merge remote-tracking branch 'origin/master' into HDDS-10059
adoroszlai Jan 29, 2024
34ea379
address review comments: use contains(), use Set, convert to constant
adoroszlai Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions ...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMRatisSnapshots.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.apache.hadoop.hdds.utils.TransactionInfo;
import org.apache.hadoop.hdds.utils.db.DBCheckpoint;
import org.apache.hadoop.hdds.utils.db.RDBCheckpointUtils;
import org.apache.hadoop.hdds.utils.db.RDBStore;
import org.apache.hadoop.ozone.MiniOzoneCluster;
import org.apache.hadoop.ozone.MiniOzoneHAClusterImpl;
import org.apache.hadoop.ozone.client.BucketArgs;
Expand All @@ -51,7 +52,6 @@
import org.apache.hadoop.ozone.om.ratis.utils.OzoneManagerRatisUtils;
import org.apache.hadoop.ozone.om.snapshot.OmSnapshotUtils;
import org.apache.ozone.test.GenericTestUtils;
import org.apache.ozone.test.tag.Unhealthy;
import org.apache.ratis.server.protocol.TermIndex;
import org.assertj.core.api.Fail;
import org.junit.jupiter.api.AfterEach;
Expand All @@ -60,8 +60,8 @@
import org.junit.jupiter.api.TestInfo;
import org.junit.jupiter.api.Timeout;
import org.junit.jupiter.api.io.TempDir;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
import org.rocksdb.RocksDB;
import org.rocksdb.RocksDBException;
import org.slf4j.Logger;
import org.slf4j.event.Level;

Expand Down Expand Up @@ -198,12 +198,12 @@ public void shutdown() {
}
}

@ParameterizedTest
@ValueSource(ints = {100})
// tried up to 1000 snapshots and this test works, but some of the
// timeouts have to be increased.
@Unhealthy("HDDS-10059")
void testInstallSnapshot(int numSnapshotsToCreate, @TempDir Path tempDir) throws Exception {
private static final int SNAPSHOTS_TO_CREATE = 100;

@Test
public void testInstallSnapshot(@TempDir Path tempDir) throws Exception {
// Get the leader OM
String leaderOMNodeId = OmFailoverProxyUtil
.getFailoverProxyProvider(objectStore.getClientProxy())
Expand Down Expand Up @@ -231,8 +231,7 @@ void testInstallSnapshot(int numSnapshotsToCreate, @TempDir Path tempDir) throws
String snapshotName = "";
List<String> keys = new ArrayList<>();
SnapshotInfo snapshotInfo = null;
for (int snapshotCount = 0; snapshotCount < numSnapshotsToCreate;
snapshotCount++) {
for (int snapshotCount = 0; snapshotCount < SNAPSHOTS_TO_CREATE; snapshotCount++) {
snapshotName = snapshotNamePrefix + snapshotCount;
keys = writeKeys(keyIncrement);
snapshotInfo = createOzoneSnapshot(leaderOM, snapshotName);
Expand Down Expand Up @@ -326,7 +325,7 @@ void testInstallSnapshot(int numSnapshotsToCreate, @TempDir Path tempDir) throws
private void checkSnapshot(OzoneManager leaderOM, OzoneManager followerOM,
String snapshotName,
List<String> keys, SnapshotInfo snapshotInfo)
throws IOException {
throws IOException, RocksDBException {
// Read back data from snapshot.
OmKeyArgs omKeyArgs = new OmKeyArgs.Builder()
.setVolumeName(volumeName)
Expand All @@ -347,18 +346,28 @@ private void checkSnapshot(OzoneManager leaderOM, OzoneManager followerOM,
Path leaderActiveDir = Paths.get(leaderMetaDir.toString(), OM_DB_NAME);
Path leaderSnapshotDir =
Paths.get(getSnapshotPath(leaderOM.getConfiguration(), snapshotInfo));

// Get list of live files on the leader.
RocksDB activeRocksDB = ((RDBStore) leaderOM.getMetadataManager().getStore())
.getDb().getManagedRocksDb().get();
// strip the leading "/".
Set<String> liveSstFiles = activeRocksDB.getLiveFiles().files.stream()
.map(s -> s.substring(1))
.collect(Collectors.toSet());

// Get the list of hardlinks from the leader. Then confirm those links
// are on the follower
int hardLinkCount = 0;
try (Stream<Path>list = Files.list(leaderSnapshotDir)) {
try (Stream<Path> list = Files.list(leaderSnapshotDir)) {
for (Path leaderSnapshotSST: list.collect(Collectors.toList())) {
String fileName = leaderSnapshotSST.getFileName().toString();
if (fileName.toLowerCase().endsWith(".sst")) {

Path leaderActiveSST =
Paths.get(leaderActiveDir.toString(), fileName);
// Skip if not hard link on the leader
if (!leaderActiveSST.toFile().exists()) {
// First confirm it is live
if (!liveSstFiles.contains(fileName)) {
continue;
}
// If it is a hard link on the leader, it should be a hard
Expand Down