HDDS-8649. Remove duplicate helper methods getDBMultipartOpenKey() #6057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
swamirishi
requested changes
Jan 22, 2024
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
Thanks for the patch @ceekay47. I have a few nitpicky comments, otherwise the changes look overall good to me.
...ne-manager/src/main/java/org/apache/hadoop/ozone/om/request/util/OMMultipartUploadUtils.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Outdated
Show resolved
Hide resolved
swamirishi
approved these changes
Jan 23, 2024
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
Thanks for the patch @ceekay47. Congrats on your first patch to the project. LGTM
Tejaskriya
pushed a commit
to Tejaskriya/ozone
that referenced
this pull request
Jan 24, 2024
k5342
pushed a commit
to pfnet/ozone
that referenced
this pull request
Feb 17, 2025
…pache#6057) (cherry picked from commit 422df39)
k5342
pushed a commit
to pfnet/ozone
that referenced
this pull request
Feb 18, 2025
…pache#6057) (cherry picked from commit 422df39)
adoroszlai
pushed a commit
to adoroszlai/ozone
that referenced
this pull request
Mar 21, 2025
…pache#6057) (cherry picked from commit 422df39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes duplicate
getDBMultipartOpenKey()helper methods in the code.There are a number of helper methods for computing the key name of a multipart upload file. This PR defines a new method
getMultipartKeyFSOinOMMetadataManagerto consolidate these methods.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8649
How was this patch tested?
Workflow run on the fork git repo.