HDDS-9387. [hsync] Reduce updating block length times at OM during hsync #6054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| omClient.hsyncKey(keyArgs, openID); | ||
| if (keyArgs.getLocationInfoList().size() == 0) { | ||
| omClient.hsyncKey(keyArgs, openID); |
Contributor
There was a problem hiding this comment.
Why do we want to hsync without any block info? Or can we return error in this case.
Contributor
Author
There was a problem hiding this comment.
hsync is called right after file is created. See TestHSync#testUncommittedBlocks.
...d-rocksdb/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedRocksObjectUtils.java
Outdated
Show resolved
Hide resolved
jojochuang
reviewed
Jan 22, 2024
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestHSync.java
Show resolved
Hide resolved
jojochuang
approved these changes
Jan 24, 2024
jojochuang
reviewed
Jan 24, 2024
...ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockOutputStreamEntryPool.java
Show resolved
Hide resolved
ChenSammi
changed the title
Contributor
|
Thanks Sammi and Ashish! |
chungen0126
pushed a commit
to chungen0126/ozone
that referenced
this pull request
May 3, 2024
chungen0126
pushed a commit
to chungen0126/ozone
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update block length at OM per block when hsync is called.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9387
How was this patch tested?
new unit tests